Skip to content

Parquet reader: only set invalid entry in dictionary when a NULL value is encountered #16142

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

Parquet reader: only set invalid entry in dictionary when a NULL value is encountered #16142

wants to merge 1 commit into from
+9 −6

Conversation

Mytherin
Copy link
Collaborator

@Mytherin Mytherin commented Feb 9, 2025

This allows the dictionary validity mask to stay uninitialized when reading a column without NULL values - which can speed up subsequent operations on these columns

@Mytherin
Copy link
Collaborator Author

Mytherin commented Feb 9, 2025

Thinking about this some more this is not a good idea - since the dictionary will now be different depending on whether or not we have already seen a NULL value. This can mess up optimizations that run directly over the dictionary and e.g. cache results.

@Mytherin Mytherin closed this Feb 9, 2025
@Mytherin Mytherin mentioned this pull request Feb 9, 2025
Merged
Mytherin added a commit that referenced this pull request Feb 10, 2025
@Mytherin
Parquet reader: only set invalid entry in the dictionary when the col…
c6d5179 
…umn has defines (#16144)

Similar to #16142 - but now using
only whether or not a column has defines instead of trying to do it
dynamically when a `NULL` value is encountered
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@Mytherin