Issue #16098: ValidEnd Parallel Vectorisation #16140
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ValidEnd was still using the old valid_start inter-chunk state variable instead of reading the correct value from the already computed ValidBegin vector. This would in turn generate incorrect bounds for RANGE FOLLOWING searches, leading to erratic frame bounds. ValidEnd was also incorrectly setting up the prev values to optimise the search, instead of having the frame functions set it up for each chunk. fixes: duckdb#16098 fixes: duckdblabs/duckdb-internal#4170
Fix test comment. fixes: duckdb#16098 fixes: duckdblabs/duckdb-internal#4170
|
Thanks! |
krlmlr
added a commit
to duckdb/duckdb-r
that referenced
this pull request
Mar 7, 2025
Issue duckdb/duckdb#16098: ValidEnd Parallel Vectorisation (duckdb/duckdb#16140)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ValidEnd was still using the old valid_start inter-chunk state variable
instead of reading the correct value from the already computed ValidBegin vector.
This would in turn generate incorrect bounds for RANGE FOLLOWING searches,
leading to erratic frame bounds.
ValidEnd was also incorrectly setting up the prev values to optimise the search,
instead of having the frame functions set it up for each chunk.
fixes: #16098
fixes: duckdblabs/duckdb-internal#4170