Fix gcc 4.8 compilation #16038
Merged
Fix gcc 4.8 compilation #16038
+5
−5
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit f6e1858. This is needed since the new syntax (that deprecates the old one) is not supported by GCC 4.8 (or maybe there is some flag that can be passed, but not worth the effort)
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This reverts commit f6e1858 (also of mine).
This is needed since the new syntax (that deprecates the old one) is not supported by GCC 4.8 (or maybe there is some flag that can be passed, but not worth the effort)
Note that this (if test is enabled) shows quite some compilation warning that we might want to address, mostly uninitialized member initializations.
Example to CI run: https://github.com/carlopi/duckdb/actions/runs/13112778639/job/36580142875#step:3:1143