Avoid running autoloading tests from remote when not deploying #16032
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
carlopi
commented
Feb 3, 2025
| @@ -124,7 +124,6 @@ jobs: | |||
|
|
|||
| - uses: ./.github/actions/build_extensions | |||
| with: | |||
| deploy_as: windows_amd64_mingw | |||
There was a problem hiding this comment.
This in particular was problematic, since here it would deploy extensions (possibly overriding the one built in R.yml) with chances that those workflows gets out-of-sync.
|
I think this is ready to go in. |
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Yet another step to streamlining uploads and fixing a problem with testing loading from remote endpoints in Windows workflow. This can't be done BEFORE actually uploading.
The tests needs to be reviewed post v1.2.0, now avoiding the failure and unifying the code more.
This avoids errors like tonight nightly run: https://github.com/duckdb/duckdb/actions/runs/13104026020/job/36557104073.