[Fix] Follow-up fix to the copy physical index PR #15998
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Do you happen to have a test where this makes a difference? Thanks! |
|
I could not reproduce the stable storage one you sent in the test runner - and the string inline one is already running in the nightlies. Should I give the storage test another shot? |
|
I don't know, this was me being curious if you had found a way to reproduce in the unittester. If not, all cool. |
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#15964
I was hoping we could copy the index without having to bind it, but that causes some issues. So, this PR addresses them by binding the index.
Fix https://github.com/duckdblabs/duckdb-internal/issues/4105
Fix https://github.com/duckdblabs/duckdb-internal/issues/4104