Skip to content

[chore] Fix Windows.yml to rely on _sign_deploy_extensions.yml #15996

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 30, 2025
Merged

[chore] Fix Windows.yml to rely on _sign_deploy_extensions.yml #15996

merged 1 commit into from
Jan 30, 2025

Conversation

carlopi
Copy link
Contributor

@carlopi carlopi commented Jan 30, 2025

This makes so all extensions go through the same path. signing_pk option of the build_all_extensions workflow is left in place as caution measure, but can/should be removed

@duckdb-draftbot duckdb-draftbot marked this pull request as draft January 30, 2025 10:28
@carlopi
[chore] Fix Windows.yml to rely on _sign_deploy_extensions.yml reusab…
9d1d8ee 
…le workflow

This makes so all extensions go through the same path.
signing_pk option of the build_all_extensions workflow is left in place as caution measure, but can/should be removed
@carlopi carlopi marked this pull request as ready for review January 30, 2025 10:29
@Mytherin Mytherin merged commit 5e7ca1c into duckdb:v1.2-histrionicus Jan 30, 2025
11 checks passed
@Mytherin
Copy link
Collaborator

Thanks!

@carlopi carlopi deleted the fix_windows_ci branch February 4, 2025 08:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
Ready For Review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@carlopi @Mytherin