Skip to content

Conversation

Tishj
Copy link
Contributor

@Tishj Tishj commented Jan 29, 2025

@Tishj Tishj marked this pull request as draft January 29, 2025 11:57
@Tishj
Copy link
Contributor Author

Tishj commented Jan 29, 2025

Thanks to Sam we narrowed it down to PhysicalUnion::BuildPipelines, if we set order_matters to true this test failure disappears.

@Tishj
Copy link
Contributor Author

Tishj commented Jan 29, 2025

@Mytherin I'm not exactly sure what the right course of action here is
Are we fine skipping this test when FORCE_ASYNC_SINK_SOURCE is set (accept that this is expected behavior), or should we look into it more deeply and fix it somehow?

@Mytherin Mytherin changed the base branch from main to v1.2-histrionicus January 29, 2025 21:44
@Mytherin
Copy link
Collaborator

Skipping the test seems fine to me - although I wonder if we want to test this behavior in the first place? Do we want to make an effort to ensure this guarantee holds up (if INSERT OR REPLACE contains duplicates we're guaranteed to have only the last duplicate in the table)?

@Tishj
Copy link
Contributor Author

Tishj commented Feb 4, 2025

I don't feel strongly about it either way

if INSERT OR REPLACE contains duplicates we're guaranteed to have only the last duplicate in the table

When executed in parallel this falls apart, but otherwise I think we can guarantee it?
But I don't know whether this is important to guarantee

@Tishj Tishj marked this pull request as ready for review February 4, 2025 13:29
@duckdb-draftbot duckdb-draftbot marked this pull request as draft February 6, 2025 13:04
@Tishj Tishj changed the base branch from v1.2-histrionicus to main February 6, 2025 13:04
@Tishj Tishj changed the title [Dev] Fix flaky test with FORCE_ASYNC_SINK_SOURCE [Dev] Remove upsert_conflict_in_different_chunk.test Feb 6, 2025
@Tishj Tishj marked this pull request as ready for review February 6, 2025 13:05
@duckdb-draftbot duckdb-draftbot marked this pull request as draft February 6, 2025 13:22
@Tishj Tishj marked this pull request as ready for review February 7, 2025 09:46
@Mytherin Mytherin merged commit d2d7ee6 into duckdb:main Feb 8, 2025
34 checks passed
@Mytherin
Copy link
Collaborator

Mytherin commented Feb 8, 2025

Thanks!

Antonov548 added a commit to Antonov548/duckdb-r that referenced this pull request Feb 27, 2025
[Dev] Fix issue related to unpacked columns and the NOT operator (duckdb/duckdb#15534)
[Dev] Remove `upsert_conflict_in_different_chunk.test` (duckdb/duckdb#15980)
krlmlr pushed a commit to duckdb/duckdb-r that referenced this pull request Mar 5, 2025
[Dev] Fix issue related to unpacked columns and the NOT operator (duckdb/duckdb#15534)
[Dev] Remove `upsert_conflict_in_different_chunk.test` (duckdb/duckdb#15980)
krlmlr added a commit to duckdb/duckdb-r that referenced this pull request May 15, 2025
[Dev] Fix issue related to unpacked columns and the NOT operator (duckdb/duckdb#15534)
[Dev] Remove `upsert_conflict_in_different_chunk.test` (duckdb/duckdb#15980)
krlmlr added a commit to duckdb/duckdb-r that referenced this pull request May 15, 2025
[Dev] Fix issue related to unpacked columns and the NOT operator (duckdb/duckdb#15534)
[Dev] Remove `upsert_conflict_in_different_chunk.test` (duckdb/duckdb#15980)
krlmlr added a commit to duckdb/duckdb-r that referenced this pull request May 17, 2025
[Dev] Fix issue related to unpacked columns and the NOT operator (duckdb/duckdb#15534)
[Dev] Remove `upsert_conflict_in_different_chunk.test` (duckdb/duckdb#15980)
krlmlr added a commit to duckdb/duckdb-r that referenced this pull request May 18, 2025
[Dev] Fix issue related to unpacked columns and the NOT operator (duckdb/duckdb#15534)
[Dev] Remove `upsert_conflict_in_different_chunk.test` (duckdb/duckdb#15980)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants