Skip to content

Conversation

Tishj
Copy link
Contributor

@Tishj Tishj commented Jan 29, 2025

This PR fixes https://github.com/duckdblabs/duckdb-internal/issues/4079

Same change as #15448 but for some reason (not sure what those are) Pyodide build doesn't use the requirements-dev.txt so this change has to be made here separately.

@duckdb-draftbot duckdb-draftbot marked this pull request as draft January 29, 2025 10:58
@Tishj Tishj marked this pull request as ready for review January 29, 2025 11:02
@pdet
Copy link
Contributor

pdet commented Jan 29, 2025

cc: @carlopi

Copy link
Contributor

@carlopi carlopi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!
This can go in for my side, the failures in the versions 3.10 / 3.11 are preexisting and probably have just to be skipped for that specific test (when on emscripten platform).

@Mytherin Mytherin changed the base branch from main to v1.2-histrionicus January 29, 2025 18:42
@Mytherin Mytherin merged commit 0fd5419 into duckdb:v1.2-histrionicus Jan 29, 2025
5 of 7 checks passed
@Mytherin
Copy link
Collaborator

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants