Remove extension definitions to prevent re-compilation of the entire system on commit #15955
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Antonov548
added a commit
to Antonov548/duckdb-r
that referenced
this pull request
Feb 26, 2025
Display schema information of currently selected database only (duckdb/duckdb#15815) Remove extension definitions to prevent re-compilation of the entire system on commit (duckdb/duckdb#15955) Throw an error when unsupported commands are used in concurrentloop (duckdb/duckdb#16009) Benchmark runner: catch and log errors + add support for `retry load N` syntax (duckdb/duckdb#16054)
krlmlr
pushed a commit
to duckdb/duckdb-r
that referenced
this pull request
Mar 5, 2025
Display schema information of currently selected database only (duckdb/duckdb#15815) Remove extension definitions to prevent re-compilation of the entire system on commit (duckdb/duckdb#15955) Throw an error when unsupported commands are used in concurrentloop (duckdb/duckdb#16009) Benchmark runner: catch and log errors + add support for `retry load N` syntax (duckdb/duckdb#16054)
krlmlr
added a commit
to duckdb/duckdb-r
that referenced
this pull request
May 15, 2025
Display schema information of currently selected database only (duckdb/duckdb#15815) Remove extension definitions to prevent re-compilation of the entire system on commit (duckdb/duckdb#15955) Throw an error when unsupported commands are used in concurrentloop (duckdb/duckdb#16009) Benchmark runner: catch and log errors + add support for `retry load N` syntax (duckdb/duckdb#16054)
krlmlr
added a commit
to duckdb/duckdb-r
that referenced
this pull request
May 15, 2025
Display schema information of currently selected database only (duckdb/duckdb#15815) Remove extension definitions to prevent re-compilation of the entire system on commit (duckdb/duckdb#15955) Throw an error when unsupported commands are used in concurrentloop (duckdb/duckdb#16009) Benchmark runner: catch and log errors + add support for `retry load N` syntax (duckdb/duckdb#16054)
krlmlr
added a commit
to duckdb/duckdb-r
that referenced
this pull request
May 17, 2025
Display schema information of currently selected database only (duckdb/duckdb#15815) Remove extension definitions to prevent re-compilation of the entire system on commit (duckdb/duckdb#15955) Throw an error when unsupported commands are used in concurrentloop (duckdb/duckdb#16009) Benchmark runner: catch and log errors + add support for `retry load N` syntax (duckdb/duckdb#16054)
krlmlr
added a commit
to duckdb/duckdb-r
that referenced
this pull request
May 18, 2025
Display schema information of currently selected database only (duckdb/duckdb#15815) Remove extension definitions to prevent re-compilation of the entire system on commit (duckdb/duckdb#15955) Throw an error when unsupported commands are used in concurrentloop (duckdb/duckdb#16009) Benchmark runner: catch and log errors + add support for `retry load N` syntax (duckdb/duckdb#16054)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The extensions add an
EXT_VERSION_[XXX]definition (e.g.EXT_VERSION_PARQUET) - which defaults to the current git hash. These definitions are not removed afterwards, leading to subsequent compilation units to all have this definition, and stacking them up as extensions get built, e.g.:autocomplete->-DEXT_VERSION_AUTOCOMPLETE=\"5001ce5bc7\"icu->-DEXT_VERSION_AUTOCOMPLETE=\"5001ce5bc7\" -DEXT_VERSION_ICU=\"5001ce5bc7\"etc...
This is not really a problem, but these definitions change when a commit is made, leading to unnecessary recompilation. As these definitions pollute also the compilation of the main source tree this leads to recompiling of the entire system upon commit. By removing the definitions we make it so that we "only" recompile the extensions on commit instead.