Skip to content

Issue #14366: Average Intervals #15864

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
Feb 6, 2025
Merged

Issue #14366: Average Intervals #15864

merged 6 commits into from
Feb 6, 2025

Conversation

hawkfish
Copy link
Contributor

@hawkfish hawkfish commented Jan 23, 2025 •
edited
Loading

  • Implement PG-compatible AVG(INTERVAL).
  • Add detailed test from PG test suite.

fixes: #14366

Richard Wesley and others added 6 commits January 10, 2025 13:44
@hawkfish hawkfish requested a review from lnkuiper January 23, 2025 17:24
@hawkfish
Copy link
Contributor Author

This is branched from temporal-avg, but I thought it should be separate.

lnkuiper
lnkuiper approved these changes Jan 27, 2025
View reviewed changes
Copy link
Contributor

@lnkuiper lnkuiper left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR! Looks good to me. This includes some changes that were merged into the v1.2-histrionicus branch, so maybe this should be merged after that branch is merged back into main?

@Mytherin Mytherin merged commit f95653e into duckdb:main Feb 6, 2025
48 checks passed
@Mytherin
Copy link
Collaborator

Mytherin commented Feb 6, 2025

Thanks!

@hawkfish hawkfish deleted the interval-avg branch February 6, 2025 15:55
@staticlibs staticlibs mentioned this pull request Feb 19, 2025
Closed
staticlibs added a commit to staticlibs/duckdb-odbc that referenced this pull request Feb 19, 2025
@staticlibs
Update isql tests after duckdb/duckdb#15864
2d1d51c 
isql tests are updated with recent changes from upstream
test_timestamp.test (1e40481).

Fixes: duckdb#64
@staticlibs staticlibs mentioned this pull request Feb 19, 2025
Merged
Mytherin added a commit to duckdb/duckdb-odbc that referenced this pull request Feb 19, 2025
@Mytherin
Merge pull request #65 from staticlibs/timestamp_avg_isqltest
d863d82 
Update isql tests after duckdb/duckdb#15864
Antonov548 added a commit to Antonov548/duckdb-r that referenced this pull request Feb 26, 2025
@Antonov548
vendor: Update vendored sources to duckdb/duckdb@f95653e
f66f6e3 
Issue duckdb/duckdb#14366: Average Intervals  (duckdb/duckdb#15864)
krlmlr pushed a commit to duckdb/duckdb-r that referenced this pull request Mar 5, 2025
@Antonov548 @krlmlr
vendor: Update vendored sources to duckdb/duckdb@f95653e
eefd6fb 
Issue duckdb/duckdb#14366: Average Intervals  (duckdb/duckdb#15864)
staticlibs added a commit to staticlibs/duckdb-odbc that referenced this pull request Apr 16, 2025
@staticlibs
Revert "Update isql tests after duckdb/duckdb#15864"
515fbb2 
This reverts commit 2d1d51c.

This needs to be reverted because the implementation of `AVG(INTERVAL)`
that was added in duckdb/duckdb#15864 is not included in
`v1.2-histrionicus` thus the `isql` test (that is present only in ODBC
repo) is failing on it.
@staticlibs staticlibs mentioned this pull request Apr 16, 2025
Merged
staticlibs added a commit to staticlibs/duckdb-odbc that referenced this pull request Apr 16, 2025
@staticlibs
Revert "Update isql tests after duckdb/duckdb#15864"
0c31871 
This reverts commit 2d1d51c.

This needs to be reverted because the implementation of `AVG(INTERVAL)`
that was added in duckdb/duckdb#15864 is not included in
`v1.2-histrionicus` thus the `isql` test (that is present only in ODBC
repo) is failing on it.
staticlibs added a commit to duckdb/duckdb-odbc that referenced this pull request Apr 16, 2025
@staticlibs
Revert "Update isql tests after duckdb/duckdb#15864"
bda8df4 
This reverts commit 2d1d51c.

This needs to be reverted because the implementation of `AVG(INTERVAL)`
that was added in duckdb/duckdb#15864 is not included in
`v1.2-histrionicus` thus the `isql` test (that is present only in ODBC
repo) is failing on it.
krlmlr added a commit to duckdb/duckdb-r that referenced this pull request May 15, 2025
@krlmlr
vendor: Update vendored sources to duckdb/duckdb@f95653e
8bf1318 
Issue duckdb/duckdb#14366: Average Intervals  (duckdb/duckdb#15864)
krlmlr added a commit to duckdb/duckdb-r that referenced this pull request May 15, 2025
@krlmlr
vendor: Update vendored sources to duckdb/duckdb@f95653e
353c125 
Issue duckdb/duckdb#14366: Average Intervals  (duckdb/duckdb#15864)
krlmlr added a commit to duckdb/duckdb-r that referenced this pull request May 17, 2025
@krlmlr
vendor: Update vendored sources to duckdb/duckdb@f95653e
a7a6cc4 
Issue duckdb/duckdb#14366: Average Intervals  (duckdb/duckdb#15864)
krlmlr added a commit to duckdb/duckdb-r that referenced this pull request May 18, 2025
@krlmlr
vendor: Update vendored sources to duckdb/duckdb@f95653e
07cfd2f 
Issue duckdb/duckdb#14366: Average Intervals  (duckdb/duckdb#15864)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
1 more reviewer

@lnkuiper lnkuiper lnkuiper approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
Ready For Review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@hawkfish @Mytherin @lnkuiper