Sniff Timestamp_TZ from CSV FIles #15730
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hawkfish
suggested changes
Jan 15, 2025
| cur_top_candidate == LogicalType::TIME || cur_top_candidate == LogicalType::TIMESTAMP)) { | ||
| cur_top_candidate == LogicalType::TIME || | ||
| (cur_top_candidate == LogicalType::TIMESTAMP && | ||
| col_type_candidates[col_type_candidates.size() - 2] != LogicalType::TIMESTAMP_TZ) || |
There was a problem hiding this comment.
Can there be only one candidate?
There was a problem hiding this comment.
LogicalType::VARCHAR is always guaranteed to exist
There was a problem hiding this comment.
I'll add an assertion though :-)
data/csv/timestamp_timezone.csv
Outdated
| 2020-01-01T00:00:00-08,midnight in San Francisco | ||
| 2020-01-01T00:00:00+00,midnight UTC +00 | ||
| 2020-01-01T00:00:00Z,midnight UTC Z | ||
| 2020-01-01T00:00:00+08:00,midnight in Taipei |
There was a problem hiding this comment.
Always fun to include fractional hours for this stuff (Asia/Kolkata +05:30:00, Pacific/Chatham +13:45, Canada/Newfoundland -03:30:00)
There was a problem hiding this comment.
Just to check if I got your comment right,
I should add:
2020-01-01T00:00:00+05:30:00,Asia/Kolkata
2020-01-01T00:00:00+13:45, Pacific/Chatham
2020-01-01T00:00:00 -03:30:00,Canada/Newfoundland
to the CSV file, right?
hawkfish
approved these changes
Jan 16, 2025
|
Thanks! |
Antonov548
added a commit
to Antonov548/duckdb-r
that referenced
this pull request
Feb 26, 2025
Sniff Timestamp_TZ from CSV FIles (duckdb/duckdb#15730)
krlmlr
pushed a commit
to duckdb/duckdb-r
that referenced
this pull request
Mar 5, 2025
Sniff Timestamp_TZ from CSV FIles (duckdb/duckdb#15730)
krlmlr
added a commit
to duckdb/duckdb-r
that referenced
this pull request
May 15, 2025
Sniff Timestamp_TZ from CSV FIles (duckdb/duckdb#15730)
krlmlr
added a commit
to duckdb/duckdb-r
that referenced
this pull request
May 15, 2025
Sniff Timestamp_TZ from CSV FIles (duckdb/duckdb#15730)
krlmlr
added a commit
to duckdb/duckdb-r
that referenced
this pull request
May 17, 2025
Sniff Timestamp_TZ from CSV FIles (duckdb/duckdb#15730)
krlmlr
added a commit
to duckdb/duckdb-r
that referenced
this pull request
May 18, 2025
Sniff Timestamp_TZ from CSV FIles (duckdb/duckdb#15730)
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix: https://github.com/duckdblabs/duckdb-internal/issues/1599