[Dev] Fix wrong result reported by Roaring Compression FinalAnalyze
#15677
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks! |
|
@Mytherin I wasnt sure if you'd agree with the use of the logger here, was expecting to have to take it out honestly |
|
I think these kinds of things are exactly what the logger is for no? |
|
I agree, but I don't think this behavior is quick to change, so perhaps doesn't require tests like this |
|
Oh yeah, I had not seen the logging checks in the tests. Agreed that should be removed. |
krlmlr
added a commit
to duckdb/duckdb-r
that referenced
this pull request
Feb 2, 2025
[Dev] Fix wrong result reported by Roaring Compression `FinalAnalyze` (duckdb/duckdb#15677)
krlmlr
added a commit
to duckdb/duckdb-r
that referenced
this pull request
Feb 2, 2025
[Dev] Fix wrong result reported by Roaring Compression `FinalAnalyze` (duckdb/duckdb#15677)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The metadata size was being calculated for all the groups in the segment, but we were adding this to the total
space_usedWe know split the
space_usedintodata_sizeandmetadata_size.metadata_sizegets recalculated with every flushed container, whereasdata_sizeis added onto for every container.We make use of the new logging system to test this! 🥳