[Dev] Fix issue related to unpacked columns and the NOT operator #15534
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Mytherin
reviewed
Jan 4, 2025
Mytherin
reviewed
Jan 7, 2025
src/planner/binder/expression/bind_unpacked_star_expression.cpp
Outdated
Show resolved
Hide resolved
|
Thanks! |
Antonov548
added a commit
to Antonov548/duckdb-r
that referenced
this pull request
Feb 27, 2025
[Dev] Fix issue related to unpacked columns and the NOT operator (duckdb/duckdb#15534) [Dev] Remove `upsert_conflict_in_different_chunk.test` (duckdb/duckdb#15980)
krlmlr
pushed a commit
to duckdb/duckdb-r
that referenced
this pull request
Mar 5, 2025
[Dev] Fix issue related to unpacked columns and the NOT operator (duckdb/duckdb#15534) [Dev] Remove `upsert_conflict_in_different_chunk.test` (duckdb/duckdb#15980)
krlmlr
added a commit
to duckdb/duckdb-r
that referenced
this pull request
May 15, 2025
[Dev] Fix issue related to unpacked columns and the NOT operator (duckdb/duckdb#15534) [Dev] Remove `upsert_conflict_in_different_chunk.test` (duckdb/duckdb#15980)
krlmlr
added a commit
to duckdb/duckdb-r
that referenced
this pull request
May 15, 2025
[Dev] Fix issue related to unpacked columns and the NOT operator (duckdb/duckdb#15534) [Dev] Remove `upsert_conflict_in_different_chunk.test` (duckdb/duckdb#15980)
krlmlr
added a commit
to duckdb/duckdb-r
that referenced
this pull request
May 17, 2025
[Dev] Fix issue related to unpacked columns and the NOT operator (duckdb/duckdb#15534) [Dev] Remove `upsert_conflict_in_different_chunk.test` (duckdb/duckdb#15980)
krlmlr
added a commit
to duckdb/duckdb-r
that referenced
this pull request
May 18, 2025
[Dev] Fix issue related to unpacked columns and the NOT operator (duckdb/duckdb#15534) [Dev] Remove `upsert_conflict_in_different_chunk.test` (duckdb/duckdb#15980)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes #15290
NOT only expected a single expression, because in the grammar it only takes a single expression
Because of
*COLUMNS(...)this can expand to multiple expressionsThe internal exception has been turned into a binder exception, disallowing the use of *COLUMNS here (if it resolves to more than a single expression)