Fix the seed of RandomLocalState to be 64bit instead of 32bits #15482
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is connected to raising RandomEngine to use 64bit state, see duckdb#13920, but initialization need to be done on full range otherwise entropy is limited when many repeated statement are executed. Note that here we only solve the problem for RandomLocalState. A wider rework of the RandomEngine API migth be also handy. Test case provided by @taniabogatsch Fixes duckdb/duckdb-rs#331 Fixes marcboeker/go-duckdb#339
github-actions bot
pushed a commit
to duckdb/duckdb-r
that referenced
this pull request
Dec 30, 2024
Fix the seed of RandomLocalState to be 64bit instead of 32bits (duckdb/duckdb#15482)
github-actions bot
added a commit
to duckdb/duckdb-r
that referenced
this pull request
Dec 30, 2024
Fix the seed of RandomLocalState to be 64bit instead of 32bits (duckdb/duckdb#15482) Co-authored-by: krlmlr <krlmlr@users.noreply.github.com>
carlopi
added a commit
to carlopi/duckdb
that referenced
this pull request
Jan 2, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is connected to raising RandomEngine to use 64bit state, see #13920, but initialization need to be done on full range otherwise entropy is limited when many repeated statement are executed.
Note that here we only solve the problem for RandomLocalState.
A wider rework of the RandomEngine API would also be also handy, since currently it takes a int64_t that can be either invalid (-1) or valid (>=0), but out of scope here given interactions with sampling PRs make it a larger change.
Test case by @taniabogatsch
Fixes duckdb/duckdb-rs#331
Fixes marcboeker/go-duckdb#339