Skip to content

[Python][Dev] Lock mypy at 1.13 #15448

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Dec 30, 2024
Merged

[Python][Dev] Lock mypy at 1.13 #15448

merged 1 commit into from
Dec 30, 2024

Conversation

Tishj
Copy link
Contributor

@Tishj Tishj commented Dec 23, 2024

1.14 introduced a change that our __init__.py doesn't, and can't comply with.

Our __init__.py looks like this:

_exported_symbols.extend([
    "Value",
    "NullValue",
    "BooleanValue",
    "UnsignedBinaryValue",
    "UnsignedShortValue",
    "UnsignedIntegerValue",
    "UnsignedLongValue",
    "BinaryValue",
    "ShortValue",
    "IntegerValue",
    "LongValue",
    "HugeIntegerValue",
    "FloatValue",
    "DoubleValue",
    "DecimalValue",
    "StringValue",
    "UUIDValue",
    "BitValue",
    "BlobValue",
    "DateValue",
    "IntervalValue",
    "TimestampValue",
    "TimestampSecondValue",
    "TimestampMilisecondValue",
    "TimestampNanosecondValue",
    "TimestampTimeZoneValue",
    "TimeValue",
    "TimeTimeZoneValue",
])

__all__ = _exported_symbols

Which I'm pretty sure is non-standard, and creates a warning, but this works for us

Mypy is not happy about this because it seems __all__ is expected to be a constant expression, and expected to be copied to the __init__.pyi file

@hannes hannes merged commit 9752082 into duckdb:main Dec 30, 2024
19 checks passed
github-actions bot pushed a commit to duckdb/duckdb-r that referenced this pull request Dec 30, 2024
@krlmlr
vendor: Update vendored sources to duckdb/duckdb@f1cdeed
eb828b8 
Fix InFilter::ToString, visible via EXPLAIN ANALYZE for example (duckdb/duckdb#15487)
[Python][Dev] Lock `mypy` at 1.13 (duckdb/duckdb#15448)
@github-actions github-actions bot mentioned this pull request Dec 30, 2024
Merged
github-actions bot added a commit to duckdb/duckdb-r that referenced this pull request Dec 30, 2024
@github-actions @krlmlr
vendor: Update vendored sources to duckdb/duckdb@f1cdeed (#912)
84462c7 
Fix InFilter::ToString, visible via EXPLAIN ANALYZE for example (duckdb/duckdb#15487)
[Python][Dev] Lock `mypy` at 1.13 (duckdb/duckdb#15448)

Co-authored-by: krlmlr <krlmlr@users.noreply.github.com>
@Tishj Tishj deleted the mypy_lock_1_13 branch January 2, 2025 10:18
@Tishj Tishj mentioned this pull request Jan 29, 2025
Merged
Mytherin added a commit that referenced this pull request Jan 29, 2025
@Mytherin
[Dev] Fix pyodide test failures (#15979)
0fd5419 
This PR fixes duckdblabs/duckdb-internal#4079

Same change as <#15448> but for
some reason (not sure what those are) Pyodide build doesn't use the
`requirements-dev.txt` so this change has to be made here separately.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Tishj @hannes