Skip to content

new answers for some JOIN benchmarks #15090

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Dec 2, 2024
Merged

new answers for some JOIN benchmarks #15090

merged 1 commit into from
Dec 2, 2024

Conversation

hmeriann
Copy link
Contributor

@hmeriann hmeriann commented Dec 2, 2024 •
edited
Loading

This PR changes the answers for the benchmarks to fix the issue https://github.com/duckdblabs/duckdb-internal/issues/3616

benchmark/micro/join/right_outer_join_left_big.benchmark
benchmark/micro/join/left_outer_join_right_big.benchmark
benchmark/micro/join/positional_join.benchmark
benchmark/micro/join/asof_join_small_probe.benchmark

so the WeeklyRegression won't fail on them.
Here is the explanation: https://github.com/duckdblabs/duckdb-internal/issues/3611#issuecomment-2511353011

@hmeriann hmeriann requested review from Tmonster and lnkuiper December 2, 2024 13:06
lnkuiper
lnkuiper approved these changes Dec 2, 2024
View reviewed changes
Copy link
Contributor

@lnkuiper lnkuiper left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is good to go from my side! The random number generation changed, so the expected benchmark results should be changed, too.

@carlopi
Copy link
Contributor

carlopi commented Dec 2, 2024

For posterity, linking here the PR #13920 that changed random() implementation (with explainer).

@Mytherin Mytherin merged commit 18fd04f into duckdb:main Dec 2, 2024
43 checks passed
krlmlr added a commit to duckdb/duckdb-r that referenced this pull request Dec 27, 2024
@krlmlr
vendor: Update vendored sources to duckdb/duckdb@405ff1f
0dc9df6 
Ensure checkpoint tasks complete on IO exceptions (duckdb/duckdb#15089)
new answers for some JOIN benchmarks (duckdb/duckdb#15090)
krlmlr added a commit to duckdb/duckdb-r that referenced this pull request Dec 27, 2024
@krlmlr
vendor: Update vendored sources to duckdb/duckdb@405ff1f
1d20ed8 
Ensure checkpoint tasks complete on IO exceptions (duckdb/duckdb#15089)
new answers for some JOIN benchmarks (duckdb/duckdb#15090)
krlmlr added a commit to duckdb/duckdb-r that referenced this pull request Dec 27, 2024
@krlmlr
vendor: Update vendored sources to duckdb/duckdb@405ff1f
70159be 
Ensure checkpoint tasks complete on IO exceptions (duckdb/duckdb#15089)
new answers for some JOIN benchmarks (duckdb/duckdb#15090)
github-actions bot pushed a commit to duckdb/duckdb-r that referenced this pull request Dec 28, 2024
@krlmlr
vendor: Update vendored sources to duckdb/duckdb@405ff1f
e739512 
Ensure checkpoint tasks complete on IO exceptions (duckdb/duckdb#15089)
new answers for some JOIN benchmarks (duckdb/duckdb#15090)
@github-actions github-actions bot mentioned this pull request Dec 28, 2024
Merged
github-actions bot added a commit to duckdb/duckdb-r that referenced this pull request Dec 28, 2024
@github-actions @krlmlr
vendor: Update vendored sources to duckdb/duckdb@405ff1f (#783)
8aa62fd 
Ensure checkpoint tasks complete on IO exceptions (duckdb/duckdb#15089)
new answers for some JOIN benchmarks (duckdb/duckdb#15090)

Co-authored-by: krlmlr <krlmlr@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Tmonster Tmonster Awaiting requested review from Tmonster

1 more reviewer

@lnkuiper lnkuiper lnkuiper approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
Ready To Merge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@hmeriann @carlopi @lnkuiper @Mytherin