Top-N: Perform global boundary checking before doing sort-key conversion #15087
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
krlmlr
added a commit
to duckdb/duckdb-r
that referenced
this pull request
Dec 27, 2024
Top-N: Perform global boundary checking before doing sort-key conversion (duckdb/duckdb#15087) Allow inputting a base hash in Regression workflow (duckdb/duckdb#15082) Avoid building for Python 3.7 on Windows (duckdb/duckdb#15085)
krlmlr
added a commit
to duckdb/duckdb-r
that referenced
this pull request
Dec 27, 2024
Top-N: Perform global boundary checking before doing sort-key conversion (duckdb/duckdb#15087) Allow inputting a base hash in Regression workflow (duckdb/duckdb#15082) Avoid building for Python 3.7 on Windows (duckdb/duckdb#15085)
krlmlr
added a commit
to duckdb/duckdb-r
that referenced
this pull request
Dec 27, 2024
Top-N: Perform global boundary checking before doing sort-key conversion (duckdb/duckdb#15087) Allow inputting a base hash in Regression workflow (duckdb/duckdb#15082) Avoid building for Python 3.7 on Windows (duckdb/duckdb#15085)
github-actions bot
pushed a commit
to duckdb/duckdb-r
that referenced
this pull request
Dec 28, 2024
Top-N: Perform global boundary checking before doing sort-key conversion (duckdb/duckdb#15087) Allow inputting a base hash in Regression workflow (duckdb/duckdb#15082) Avoid building for Python 3.7 on Windows (duckdb/duckdb#15085)
github-actions bot
added a commit
to duckdb/duckdb-r
that referenced
this pull request
Dec 28, 2024
Top-N: Perform global boundary checking before doing sort-key conversion (duckdb/duckdb#15087) Allow inputting a base hash in Regression workflow (duckdb/duckdb#15082) Avoid building for Python 3.7 on Windows (duckdb/duckdb#15085) Co-authored-by: krlmlr <krlmlr@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is essentially a partial revert of #14424 - that fixes a performance regression that was caused by the Top-N operator doing the global boundary checking after constructing the sort key, instead of before. This meant that, even for rows where we would be certain they would not be added to the heap, we would be constructing sort keys. This PR brings back the old code that allows the boundary values to be checked directly on the sort keys. In order to facilitate this, we deserialize the global boundary value (stored as a sort key) back into a
DataChunkthat can be compared against directly.