[Python][Dev] Fix issues with new/updated tests in the python sqllogictest implementation #14850
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Tishj
commented
Nov 15, 2024
| @@ -48,6 +48,9 @@ SELECT * FROM integers | |||
| ---- | |||
| does not exist | |||
|
|
|||
| statement ok | |||
| drop view integers_view; | |||
There was a problem hiding this comment.
@Mytherin this is odd right?
The database we're importing has integers_view, and we already have integers_view defined still (without this change), so I would expect the IMPORT DATABASE call to fail ?
There was a problem hiding this comment.
I think the test runner swallows errors of multi-statement queries currently (such as import database or pivot). There was an open issue around this somewhere
There was a problem hiding this comment.
That does sound familiar, I think we indeed have an open issue for that, thanks 👍
|
Thanks! |
github-actions bot
pushed a commit
to duckdb/duckdb-r
that referenced
this pull request
Dec 22, 2024
add function ends_with back (duckdb/duckdb#14859) [Python][Dev] Fix issues with new/updated tests in the python sqllogictest implementation (duckdb/duckdb#14850) [Python][Dev] Skip `test_pandas_selection` on Python3.8 (duckdb/duckdb#14851)
github-actions bot
added a commit
to duckdb/duckdb-r
that referenced
this pull request
Dec 22, 2024
add function ends_with back (duckdb/duckdb#14859) [Python][Dev] Fix issues with new/updated tests in the python sqllogictest implementation (duckdb/duckdb#14850) [Python][Dev] Skip `test_pandas_selection` on Python3.8 (duckdb/duckdb#14851) Co-authored-by: krlmlr <krlmlr@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes the failing python sqllogictest nightly-test run
Almost all of these are very benign, there is one adjustment I had to make that made me raise an eyebrow.
Possibly pointing to a problem in the C++ API ?
In
test/sql/attach/attach_export_import.testI've had to add adrop view integers_viewstatement to get the test to pass on the python sqllogictester, which makes me wonder: why does the C++ variant not run into this same problem?Or is the error somehow getting swallowed?