Value interface & serialization clean-up #14710
Merged
+227
−209
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This got me thinking that we probably do this for |
Vectors only serialize their data - the type is serialized in the DataChunk: serializer.WriteProperty(100, "has_validity_mask", ...)
serializer.WriteProperty(101, "validity", ...)
serializer.WriteProperty(102, "data", ...)
serializer.WriteList(103, "children", ...) |
github-actions bot
pushed a commit
to duckdb/duckdb-r
that referenced
this pull request
Dec 20, 2024
Value interface & serialization clean-up (duckdb/duckdb#14710)
krlmlr
added a commit
to duckdb/duckdb-r
that referenced
this pull request
Dec 21, 2024
Value interface & serialization clean-up (duckdb/duckdb#14710)
github-actions bot
added a commit
to duckdb/duckdb-r
that referenced
this pull request
Dec 21, 2024
Value interface & serialization clean-up (duckdb/duckdb#14710) Co-authored-by: krlmlr <krlmlr@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR does some clean-up in the Value interface and serialization:
Value::EMPTYLISTandValue::EMPTYARRAYare removed, instead the interfaceValue::LIST(type, values)can be used to generate an empty list/arrayValue::MAPandValue::STRUCTnow correctly insert casts to enforce that the values are internally consistent with the defined typesLogicalType::ANYis explicitly supported in nested value types - in which case these types are ignored, i.e. we can doValue::LIST(LogicalType::ANY, values)with a list of values of any typeLogicalType::ANY). Instead, the type from the upper-layer is used (i.e. if we haveLogicalType::LIST(LogicalType::INT), the child elements are deserialized asLogicalType::INT).Valuealso in nested values, unless the serialization version is set to>= 1.2.0.