Add missing global options to Python's write_parquet
#14766
Merged
+196
−11
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions bot
pushed a commit
to duckdb/duckdb-r
that referenced
this pull request
Dec 21, 2024
Add operator name to profiling output (duckdb/duckdb#14744) Add missing global options to Python's `write_parquet` (duckdb/duckdb#14766)
github-actions bot
added a commit
to duckdb/duckdb-r
that referenced
this pull request
Dec 21, 2024
Add operator name to profiling output (duckdb/duckdb#14744) Add missing global options to Python's `write_parquet` (duckdb/duckdb#14766) Co-authored-by: krlmlr <krlmlr@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds more options to DuckDB's Python Relational API for
write_parquet, matching theCOPY TOoptions, addressing #8896:partition_bywrite_partition_columnsoverwriteper_thread_outputuse_tmp_fileappendI would also like to note that the
overwriteoption that was added in theto_csvfunction (#10382) technically passesoverwrite_or_ignoreto the underlying engine:duckdb/tools/pythonpkg/src/pyrelation.cpp
Lines 1291 to 1296 in fd5de06
In order to match this behavior, I've also implemented it the same way.
Changing it to pass
overwriteand introducingoverwrite_or_ignoreas an option would be a breaking change, thus I've avoided doing it.I've also improved the
test_to_parquettests by introducing new tests for the above mentioned flags, as well as parameterizing the Pandas engine (similar to thetest_to_csvtests – using bothNumpyPandasandArrowPandas).This PR also makes the Python stubs for
{to,write}_{csv,parquet}both match, as they are technically aliases.