Skip to content

Conversation

Giorgi
Copy link
Contributor

@Giorgi Giorgi commented Nov 4, 2024

No description provided.

Copy link
Contributor

@Tishj Tishj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@Giorgi Giorgi changed the base branch from feature to main November 5, 2024 08:50
@Giorgi Giorgi marked this pull request as ready for review November 5, 2024 18:50
@duckdb-draftbot duckdb-draftbot marked this pull request as draft November 5, 2024 18:55
@Giorgi Giorgi marked this pull request as ready for review November 5, 2024 18:55
@duckdb-draftbot duckdb-draftbot marked this pull request as draft November 5, 2024 18:58
@Giorgi Giorgi marked this pull request as ready for review November 5, 2024 18:58
@Maxxen
Copy link
Member

Maxxen commented Nov 5, 2024

Thinking about the API consistency, would it be more fitting if these were called duckdb_create_null_value (like e.g. duckdb_create_list_value) and, presumably, something like duckdb_is_null_value?

@duckdb-draftbot duckdb-draftbot marked this pull request as draft November 5, 2024 19:19
@Giorgi Giorgi marked this pull request as ready for review November 5, 2024 19:19
@Giorgi
Copy link
Contributor Author

Giorgi commented Nov 5, 2024

@Maxxen Those names sound better, renamed.

@Mytherin Mytherin merged commit ab29daf into duckdb:main Nov 6, 2024
42 checks passed
@Mytherin
Copy link
Collaborator

Mytherin commented Nov 6, 2024

Thanks!

github-actions bot pushed a commit to duckdb/duckdb-r that referenced this pull request Dec 21, 2024
Add functions for handling null duckdb_values (duckdb/duckdb#14687)
github-actions bot added a commit to duckdb/duckdb-r that referenced this pull request Dec 21, 2024
Add functions for handling null duckdb_values (duckdb/duckdb#14687)

Co-authored-by: krlmlr <krlmlr@users.noreply.github.com>
@Giorgi Giorgi deleted the feature branch February 22, 2025 19:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants