Skip to content

Remove most BUILD_ options for extensions, using CORE_EXTENSIONS #14531

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Oct 25, 2024
Merged

Remove most BUILD_ options for extensions, using CORE_EXTENSIONS #14531

merged 4 commits into from
Oct 25, 2024

Conversation

carlopi
Copy link
Contributor

@carlopi carlopi commented Oct 24, 2024

Only exception is BUILD_JEMALLOC, given jemalloc is special in many regards.

Plan is to do first a round on this, then adding a warning to use those in Makefile, then moving the warning to error.

This might need a couple of iterations, to clean up on ancillary repos (like the docs) but getting there.

Proper heavy lifting is done by CORE_EXTENSIONS option, introduced in #13116.

Once this is in, moving extensions out of tree should become simpler and one more difference removed between in and out of tree.

@carlopi carlopi mentioned this pull request Oct 24, 2024
Merged
@carlopi
Copy link
Contributor Author

carlopi commented Oct 24, 2024

Lots of red crosses, but I think that for now none is on this PR (some networking, some weird one on RealNest regression that I saw on other PRs already, some connected to feature failures on nigthly).

This is a step to removing httpfs from in-tree to out-of-tree, but I though it was better done in steps.

@carlopi carlopi mentioned this pull request Oct 24, 2024
Closed
samansmink
samansmink approved these changes Oct 25, 2024
View reviewed changes
Copy link
Contributor

@samansmink samansmink left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense to me!

@Mytherin
Copy link
Collaborator

Plan is to do first a round on this, then adding a warning to use those in Makefile, then moving the warning to error.

I don't really follow what the point of removing this from the Makefile is? For development I feel it is much easier to do BUILD_HTTPFS=1 make than CORE_EXTENSIONS='httpfs;parquet;json' (or whatever list of extensions you want to build). Maybe the Makefile can be written to set CORE_EXTENSIONS instead?

@carlopi
Copy link
Contributor Author

carlopi commented Oct 25, 2024

@Mytherin: yes, we can try to avoid breaking stuff downstream.

Then that's scoped down, but this can likely go in.

@Mytherin Mytherin merged commit b9558fe into duckdb:feature Oct 25, 2024
38 of 61 checks passed
@Mytherin
Copy link
Collaborator

Agreed, thanks!

@carlopi carlopi deleted the no_build_x branch October 25, 2024 13:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Mytherin Mytherin Awaiting requested review from Mytherin

1 more reviewer

@samansmink samansmink samansmink approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
Ready For Review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@carlopi @Mytherin @samansmink