Python 3.7 tests are particularly brittle, we will keep building wheels but avoid testing them #14510
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I had tested this on my fork, skips as intended only for 3.7 |
github-actions bot
pushed a commit
to duckdb/duckdb-r
that referenced
this pull request
Nov 2, 2024
Being more restrictive with the names option in the csv reader (duckdb/duckdb#14466) Python 3.7 tests are particularly brittle, we will keep building wheels but avoid testing them (duckdb/duckdb#14510)
github-actions bot
added a commit
to duckdb/duckdb-r
that referenced
this pull request
Nov 2, 2024
Being more restrictive with the names option in the csv reader (duckdb/duckdb#14466) Python 3.7 tests are particularly brittle, we will keep building wheels but avoid testing them (duckdb/duckdb#14510) Co-authored-by: krlmlr <krlmlr@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Discussed with @Mytherin, Python 3.7 is end of life already, we keep the support just since it seems weird to remove what currently is working (but keeps generating noise).