Test fixes for new arrow release #14593
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This looks to make sense to me, one thing to consider, @pdet, can you trigger the whole set of Python CI on your fork? It should be a matter of going to pdet/duckdb, "Action" tab, then select Python, then trigger it selecting "arrow_18" as the branch. Thanks (this is basically to cut some latency, since otherwise we will discover that only tonight) |
github-actions bot
pushed a commit
to duckdb/duckdb-r
that referenced
this pull request
Nov 3, 2024
Unexpected result comparing blob (duckdb/duckdb#14604) CI: Add repo name to labelling script (duckdb/duckdb#14612) CI: Fix labelling bot (duckdb/duckdb#14611) Test fixes for new arrow release (duckdb/duckdb#14593)
github-actions bot
added a commit
to duckdb/duckdb-r
that referenced
this pull request
Nov 3, 2024
Unexpected result comparing blob (duckdb/duckdb#14604) CI: Add repo name to labelling script (duckdb/duckdb#14612) CI: Fix labelling bot (duckdb/duckdb#14611) Test fixes for new arrow release (duckdb/duckdb#14593) Co-authored-by: krlmlr <krlmlr@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PyArrow 18 comes with the canonical extensions pre-registered. Hence, this new behavior breaks a lot of our test suit that would take care of registering/ensuring correctness. This PR fixes our CI by adjusting our tests.