Cas strong #14592
Merged
Cas strong #14592
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
CC @gropaul |
|
I think this is ready to go, but due to some arrow failures a bunch of tests got skipped |
|
Thanks! |
|
Thank you for the fix! |
github-actions bot
added a commit
to duckdb/duckdb-r
that referenced
this pull request
Nov 2, 2024
Cas strong (duckdb/duckdb#14592) Co-authored-by: krlmlr <krlmlr@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #14389 and reverts #14173 (bringing back the salt).
Although I don't think this should affect correctness (from cppreference.com):
This gave us correctness issues with older GCC versions (< 10.x) on ARM64. We rarely use CAS operations, so this isn't a big diff. I've added
std::memory_orderto improve the performance (copying the usage inconcurrentqueue.h). Since it is difficult to programmatically disable "incorrect" usage, I've added a comment inatomic.hppthat describes the issue.I've also changed usage of
MetadataPointerto a const reference since older GCC versions were throwing a warning.