HTTPFS: HTTPException no longer inherits from IOException #14585
+7
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This looks good to me. Given we are in the process of moving httpfs out of core (duckdb PR #14546 waiting for CI, external repo that looks ready is at https://github.com/duckdb/duckdb_httpfs), this PR could use being mirrored also to duckdb/duckdb_httpfs, and that could make the solution be already available (say for people that do |
carlopi
added a commit
to duckdb/duckdb-httpfs
that referenced
this pull request
Oct 28, 2024
|
I opened a PR with the same change here: duckdb/duckdb-httpfs#1 (mostly to test whether this makes sense) |
github-actions bot
pushed a commit
to duckdb/duckdb-r
that referenced
this pull request
Nov 2, 2024
[bufferpool] Fix PurgeAgedBlocksInternal() evictions (duckdb/duckdb#14446) HTTPFS: HTTPException no longer inherits from IOException (duckdb/duckdb#14585)
github-actions bot
added a commit
to duckdb/duckdb-r
that referenced
this pull request
Nov 2, 2024
[bufferpool] Fix PurgeAgedBlocksInternal() evictions (duckdb/duckdb#14446) HTTPFS: HTTPException no longer inherits from IOException (duckdb/duckdb#14585) Co-authored-by: krlmlr <krlmlr@users.noreply.github.com>
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes https://github.com/duckdblabs/duckdb-internal/issues/3302