Skip to content

Fixing an issue with parquet dictionary reading #14438

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Oct 22, 2024
Merged

Fixing an issue with parquet dictionary reading #14438

merged 4 commits into from
Oct 22, 2024

Conversation

hannes
Copy link
Member

@hannes hannes commented Oct 18, 2024

Fix an issue when reading from partial pages with the new dictionary handling added in #14194

@Mytherin
Copy link
Collaborator

Thanks for the PR! LGTM - but I do think the regression failures might be related:

INTERNAL Error: Operation requires a flat vector but a non-flat vector was encountered
This error signals an assertion failure within DuckDB. This usually occurs due to unexpected conditions or errors in the program's logic.
For more information, see https://duckdb.org/docs/dev/internal_errors
FATAL Error: Failed: database has been invalidated because of a previous fatal error. The database must be restarted prior to being used again.

Perhaps a Flatten of the Dictionary vector is required still before calling Copy

@duckdb-draftbot duckdb-draftbot marked this pull request as draft October 21, 2024 07:19
@hannes hannes marked this pull request as ready for review October 21, 2024 07:19
@duckdb-draftbot duckdb-draftbot marked this pull request as draft October 21, 2024 10:58
@Mytherin Mytherin marked this pull request as ready for review October 21, 2024 12:15
@duckdb-draftbot duckdb-draftbot marked this pull request as draft October 21, 2024 14:58
@hannes hannes marked this pull request as ready for review October 21, 2024 14:58
@hannes hannes merged commit d60103a into duckdb:feature Oct 22, 2024
42 checks passed
@hannes hannes deleted the parquetdictionaryveryhotfix branch October 29, 2024 15:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@hannes @Mytherin