Skip to content

Conversation

pdet
Copy link
Contributor

@pdet pdet commented Oct 17, 2024

This PR fixes two issues.

  1. Makes sure to properly pass rejects parameters to sniff_csv.
  2. Small correction on the sniffer to properly detect options when ingore_errors=true

Fix: #14393

@Mytherin
Copy link
Collaborator

Thanks! LGTM

@Mytherin Mytherin merged commit aed52f5 into duckdb:main Oct 18, 2024
43 checks passed
github-actions bot pushed a commit to duckdb/duckdb-r that referenced this pull request Nov 2, 2024
Sniff CSV rejects options and small sniffer fix for ignore_errors (duckdb/duckdb#14417)
github-actions bot added a commit to duckdb/duckdb-r that referenced this pull request Nov 2, 2024
Sniff CSV rejects options and small sniffer fix for ignore_errors (duckdb/duckdb#14417)

Co-authored-by: krlmlr <krlmlr@users.noreply.github.com>
@pdet pdet deleted the fix_sniff_rejects branch November 27, 2024 12:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

read_csv does not detect columns correctly with rejects_table
2 participants