Skip to content

Fix pointer indirection in pyrelation.cpp #14403

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 17, 2024
Merged

Fix pointer indirection in pyrelation.cpp #14403

merged 1 commit into from
Oct 17, 2024

Conversation

carlopi
Copy link
Contributor

@carlopi carlopi commented Oct 16, 2024 •
edited
Loading

I am not sure how it could compile in some platforms (basic Python CI) but not in others (Pyodide, that is clang-based emscripten)

Connected to #14319

For example: https://github.com/duckdb/duckdb/actions/runs/11372106923/job/31635971994?pr=14402#step:8:13491

        src/pyrelation.cpp:938:56: error: ‘class duckdb::shared_ptr<duckdb::ClientContextWrapper>’ has no member named ‘GetContext’
          938 |   auto &config = ClientConfig::GetConfig(*rel->context.GetContext());
              |                                                        ^~~~~~~~~~

@carlopi
Fixup pointer indirection precedence rules
deb9d6a 
I am not sure how it could compile in some platforms (basic Python CI)
but not in others (Pyodide, that is clang-based emscripten)
@carlopi carlopi force-pushed the fix_pointer_indirection_feature branch from 4925c62 to deb9d6a Compare October 16, 2024 19:49
@duckdb-draftbot duckdb-draftbot marked this pull request as draft October 16, 2024 19:49
@carlopi carlopi marked this pull request as ready for review October 16, 2024 19:56
@carlopi carlopi changed the title Fix pointer indirection Fix pointer indirection in pyrelation.cpp Oct 17, 2024
@Mytherin Mytherin merged commit d18cbea into duckdb:feature Oct 17, 2024
21 checks passed
@Mytherin
Copy link
Collaborator

Thanks!

@Mytherin
Copy link
Collaborator

The context on why this failed is that the CI of the PR that this was in ran against main, was retargeted against feature, and then merged.

@carlopi carlopi deleted the fix_pointer_indirection_feature branch February 4, 2025 08:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
Ready For Review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@carlopi @Mytherin