[Dev] Further optimize the CDC ValidityMask deserialization #14448
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looking at the regressions tests, the old version seems to be faster (by a very thin margin) ?? |
|
Thanks for the PR! LGTM. I doubt the regression test results are related - ragged ends are pretty rare. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR implements the suggestion made by Richard
When a
validity_tis used for <ValidityMask::BITS_PER_VALUEvalues, the least significant bits are set, i.e ifValidityMask::BITS_PER_VALUEwas 85 values uses :
xxx4 3210For that we can construct the mask:
0001 1111To check that all bits are set for those values
Given that
ValidityMask::BITS_PER_VALUEis 64, we save 1<=n<64 function calls by doing this