[bufferpool] Fix PurgeAgedBlocksInternal() evictions #14446
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for the PR! LGTM - can you just run the formatter? |
|
I submitted a fix with the formatter - but am now seeing a test failure that looks probably unrelated (Julia 1.7). Curious if it'd be possible to get another round of review? Thanks! @Mytherin |
|
Thanks! |
github-actions bot
pushed a commit
to duckdb/duckdb-r
that referenced
this pull request
Nov 2, 2024
[bufferpool] Fix PurgeAgedBlocksInternal() evictions (duckdb/duckdb#14446) HTTPFS: HTTPException no longer inherits from IOException (duckdb/duckdb#14585)
github-actions bot
added a commit
to duckdb/duckdb-r
that referenced
this pull request
Nov 2, 2024
[bufferpool] Fix PurgeAgedBlocksInternal() evictions (duckdb/duckdb#14446) HTTPFS: HTTPException no longer inherits from IOException (duckdb/duckdb#14585) Co-authored-by: krlmlr <krlmlr@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The eviction queue expects the lambda to return true to continue and false to exit:
duckdb/src/storage/buffer/buffer_pool.cpp
Line 378 in aed52f5
duckdb/src/storage/buffer/buffer_pool.cpp
Line 345 in aed52f5