Avoid throwing InternalException on reading secret #14336
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Secrets are basically untrusted input, even if they come from future versions of DuckDB that might have changed the availably types / providers. As such it's fine to throw a recoverable exception here.
a9e1494 to
c61a3e6
Compare
|
Thanks! |
github-actions bot
pushed a commit
to duckdb/duckdb-r
that referenced
this pull request
Oct 17, 2024
Avoid throwing InternalException on reading secret (duckdb/duckdb#14336)
github-actions bot
added a commit
to duckdb/duckdb-r
that referenced
this pull request
Oct 17, 2024
Avoid throwing InternalException on reading secret (duckdb/duckdb#14336) Co-authored-by: krlmlr <krlmlr@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Secrets are basically untrusted input, even if they come from future versions of DuckDB that might have changed the availably types / providers. As such it's fine to throw a recoverable exception here.
Connected to the comment to #14332 at https://github.com/duckdb/duckdb/pull/14332/files#r1797295669.