[Python] Use an ArrowQueryResult in FetchArrowTable when possible.
#14319
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…t can't be fetched incrementally, so this banks on the fact that the query is executed and the result is then fetched in its entirety
|
Thanks for the PR! LGTM - perhaps we can add some benchmarks as well to verify this is being used correctly and has the desired result? |
import duckdb
import time
duckdb.execute("""
create table tbl as select * from range(10_000_000)
""")
start = time.time()
res = duckdb.sql("select * from tbl").arrow()
stop = time.time()
print(stop - start)
The difference:
|
|
Also tested with strings, booleans, nested structures ( The nested lists are somewhat equal to the |
|
Very nice results, thanks! |
Mytherin
added a commit
that referenced
this pull request
Oct 17, 2024
I am not sure how it could compile in some platforms (basic Python CI) but not in others (Pyodide, that is clang-based emscripten) Connected to #14319 For example: https://github.com/duckdb/duckdb/actions/runs/11372106923/job/31635971994?pr=14402#step:8:13491 ``` src/pyrelation.cpp:938:56: error: ‘class duckdb::shared_ptr<duckdb::ClientContextWrapper>’ has no member named ‘GetContext’ 938 | auto &config = ClientConfig::GetConfig(*rel->context.GetContext()); | ^~~~~~~~~~ ```
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ArrowQueryResult can't be fetched incrementally, so this relies on the fact that the query is executed and the result is then fetched in its entirety.
This path will be used when
sqlwas used to create a DuckDBPyRelation andpolarsorarrowwas then used to fully consume the result into a polars DataFrame or a pyarrow ArrowTable respectively.