Change Makefile to correctly handle DISABLE_SANITIZER and DISABLE_UBSAN #14316
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Without this change disabling having both `DISABLE_UBSAN` and `DISABLE_SANITIZER` set to `1` would result in only ubsan to be disabled. Related issue in pg_duckdb: duckdb/pg_duckdb#270
|
Thanks! LGTM |
github-actions bot
pushed a commit
to duckdb/duckdb-r
that referenced
this pull request
Oct 17, 2024
[CSV Reader] Making escape not limited to only quotes (duckdb/duckdb#14314) Change Makefile to correctly handle DISABLE_SANITIZER and DISABLE_UBSAN (duckdb/duckdb#14316)
github-actions bot
added a commit
to duckdb/duckdb-r
that referenced
this pull request
Oct 17, 2024
[CSV Reader] Making escape not limited to only quotes (duckdb/duckdb#14314) Change Makefile to correctly handle DISABLE_SANITIZER and DISABLE_UBSAN (duckdb/duckdb#14316) Co-authored-by: krlmlr <krlmlr@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Without this change disabling having both
DISABLE_UBSANandDISABLE_SANITIZERset to1would result in only ubsan to be disabled, but the sanitizer still being enabled.Related issue in pg_duckdb: duckdb/pg_duckdb#270