Tidy Check to do complete run also on feature #14394
Merged
+4
−4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
For example I triggered on my fork https://github.com/carlopi/duckdb/actions/runs/11362829776 a complete run on feature (after tentatively already merging this :) ), to check whether this works (I would expect so) and to discover what is currently off. |
|
Thanks! Looks like the linked CI run is failing in your fork for reasons unrelated to the tidy checks themselves. Could you have a look? |
7d26a56 to
c4dc3d5
Compare
|
New run eventually: https://github.com/carlopi/duckdb/actions/runs/11363878681 I will later check. |
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Connected to conversation at #14384 (comment).
Basically logic after the PR will be as follow:
on
mainorfeature: do complete checkelse: do check only the diff.
Note that feature is not triggered automatically (not even on nightly), so this will have no difference as is, but allows this to be triggered manually and check the results.
Independently to be reviewed what should run on nightly.