Skip to content

Conversation

Mytherin
Copy link
Collaborator

This can happen when emitting arrow tables with large lists.

@Mytherin
Copy link
Collaborator Author

Mytherin commented Oct 15, 2024

The tidy-check failure is unrelated - but this failure does remind me that we should be running clang-tidy on all files (not just on the changeset of PRs) in the nightly tests, as failures can sneak in and remain undetected otherwise. CC @carlopi

@Mytherin Mytherin merged commit fb51e97 into duckdb:feature Oct 16, 2024
35 of 36 checks passed
@carlopi
Copy link
Contributor

carlopi commented Oct 16, 2024

The tidy-check failure is unrelated - but this failure does remind me that we should be running clang-tidy on all files (not just on the changeset of PRs) in the nightly tests, as failures can sneak in and remain undetected otherwise. CC @carlopi

I think this is already the behaviour (sort of), but this do not accounts for feature (and there are no nightly run on feature on any case).

Example: on last night CodeQuality run (run on main) the complete version Tidy Check step (example: https://github.com/duckdb/duckdb/actions/runs/11356627641/job/31588215423, , 1h 16') has been taken, while on regular PR the Tidy Check Diff step is taken (example: https://github.com/duckdb/duckdb/actions/runs/11349485053/job/31565802783, 55 seconds).

I will add the complete step also on feature, that is easy but has no immediate effect.
We can talk about how / when to trigger CI also on feature. But at least that should allow to trigger it on request.

Mytherin added a commit that referenced this pull request Oct 16, 2024
Connected to conversation at
#14384 (comment).

Basically logic after the PR will be as follow:

on `main` or `feature`: do complete check
else: do check only the diff.

Note that feature is not triggered automatically (not even on nightly),
so this will have no difference as is, but allows this to be triggered
manually and check the results.

Independently to be reviewed what should run on nightly.
@Mytherin Mytherin deleted the morehelpfulerrormessage branch December 8, 2024 06:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants