[Dev] Update vendored ZSTD to v1.5.6 #14360
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…it works properly
Tishj
commented
Oct 15, 2024
|
Are we sure we want to add the x86 assembly version? I vaguely recall stripping that before... |
I think I stripped the assembly optimizations? |
Tishj
commented
Oct 16, 2024
|
ah right you already removed it never mind, last time I looked I saw the .S file being added |
Yea I initially had it in, but having it listed as source still didn't compile it correctly so I figured it wasn't worth the hassle of supporting properly |
Mytherin
reviewed
Oct 16, 2024
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR was sparked by work on new compression related functionality, which made me notice that
ZDICT_trainFromBuffer_fastCoverwas missing.In an attempt to add the definition for that function, I was already bringing in 6+ new files, so I figured I would spin it off in a new PR that updates the entire ZSTD library we vendor to 1.5.6 (and adds the missing function definitions + files)