[Appender] Support appending to table with generated columns #14346
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks! |
github-actions bot
pushed a commit
to duckdb/duckdb-r
that referenced
this pull request
Oct 17, 2024
[Appender] Support appending to table with generated columns (duckdb/duckdb#14346) JSON reader - never generate maps if map_inference_threshold is -1 (duckdb/duckdb#14348)
github-actions bot
added a commit
to duckdb/duckdb-r
that referenced
this pull request
Oct 17, 2024
[Appender] Support appending to table with generated columns (duckdb/duckdb#14346) JSON reader - never generate maps if map_inference_threshold is -1 (duckdb/duckdb#14348) Co-authored-by: krlmlr <krlmlr@users.noreply.github.com>
andrewhamon
added a commit
to andrewhamon/duckdb-rs
that referenced
this pull request
Nov 27, 2024
Prior to duckdb/duckdb#14346, the C API did not support appending to tables with computed columns. This would cause panics until duckdb#296, where a test was introduced asserting that an append to a table with computed columns returns an error value. Now that appending to is supported, update the test to reflect that.
andrewhamon
added a commit
to andrewhamon/duckdb-rs
that referenced
this pull request
Nov 27, 2024
Prior to duckdb/duckdb#14346, the C API did not support appending to tables with computed columns. This would cause panics until duckdb#296, where a test was introduced asserting that an append to a table with computed columns returns an error value. Now that appending to is supported, update the test to reflect that.
andrewhamon
added a commit
to andrewhamon/duckdb-rs
that referenced
this pull request
Nov 27, 2024
Prior to duckdb/duckdb#14346, the C API did not support appending to tables with computed columns. This would cause panics until duckdb#296, where a test was introduced asserting that an append to a table with computed columns returns an error value. Now that appending to is supported, update the test to reflect that.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes #14343
The chunk we create and fill for a table in the Appender should not contain Vectors for generated columns, these are added later in the LocalAppend call.
Now they are ignored and no longer cause a "Call to EndRow before all columns have been appended to!" error.