Skip to content

Conversation

flashmouse
Copy link
Contributor

this pr try to fix #14232.

@Mytherin Mytherin requested a review from lnkuiper October 7, 2024 06:54
Copy link
Contributor

@lnkuiper lnkuiper left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fix! This looks good to me. This was initially added by @pdet when he removed the null_values_are_equal field for joins. Maybe he knows why this was here and if it can be safely removed?

@Mytherin Mytherin merged commit 405e15f into duckdb:main Oct 7, 2024
40 checks passed
@Mytherin
Copy link
Collaborator

Mytherin commented Oct 7, 2024

Thanks!

@flashmouse flashmouse deleted the issue_14232 branch October 13, 2024 04:56
github-actions bot pushed a commit to duckdb/duckdb-r that referenced this pull request Oct 16, 2024
Fix duckdb/duckdb#14232: fix deliminator optimizer (duckdb/duckdb#14238)
[Python] Don't allow construction of DuckDBPyType from empty Dict type (duckdb/duckdb#14221)
github-actions bot added a commit to duckdb/duckdb-r that referenced this pull request Oct 16, 2024
Fix duckdb/duckdb#14232: fix deliminator optimizer (duckdb/duckdb#14238)
[Python] Don't allow construction of DuckDBPyType from empty Dict type (duckdb/duckdb#14221)

Co-authored-by: krlmlr <krlmlr@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Incorrect results for IN clause
3 participants