Add option to ignore GeoParquet, disable spatial autoloading when reading GeoParquet #14297
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
carlopi
reviewed
Oct 9, 2024
| const auto is_loaded = ExtensionHelper::TryAutoLoadExtension(context, "spatial"); | ||
| if (!is_loaded) { | ||
| // Spatial extension is not available, we can't make use of the metadata anyway. | ||
| yyjson_doc_free(geo_metadata); |
There was a problem hiding this comment.
This needs to stay in?
And possibly also the comment // Check if the spatial extension is loaded, or try to autoload it. could be fixed
e51ed8a to
2c9dcd2
Compare
Mytherin
reviewed
Oct 10, 2024
…n checking if conversion is enabled as well
|
Thanks! |
github-actions bot
pushed a commit
to duckdb/duckdb-r
that referenced
this pull request
Oct 16, 2024
Add option to ignore GeoParquet, disable spatial autoloading when reading GeoParquet (duckdb/duckdb#14297)
github-actions bot
added a commit
to duckdb/duckdb-r
that referenced
this pull request
Oct 16, 2024
Add option to ignore GeoParquet, disable spatial autoloading when reading GeoParquet (duckdb/duckdb#14297) Co-authored-by: krlmlr <krlmlr@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes duckdb/duckdb-node#124
Closes duckdb/duckdb-spatial#423
This PR changes the GeoParquet reading behavior so that the spatial extension is no longer auto-loaded when GeoParquet metadata is detected. Spatial was not marked as autoloadable and the way the load was issued did not respect auto loading settings either. If spatial would become auto-loadable in the future we can change this behavior back (but this time also respect auto loading settings).
This PR also adds a new setting to the parquet extension
enable_geoparquet_conversion = true (default)which controls whether geometry data will be converted when reading/writing GeoParquet files (and the spatial extension is loaded). This enables you to "fall back" to reading writing parquet files normally even if they have geoparquet metadata. This is primarily useful when trying to read a geoparquet file that is incompatible with the current geoparquet support in duckdb, either because it uses an unsupported version/encoding or because it is non-standards compliant (or the metadata is broken in some other way).Additionally, I've also moved over the geoparquet tests and test files into this repository for now. Since they
require spatialthey won't be invoked during our normal CI runs (I think?), but it still useful when testing locally.