allow external cardinality information (e.g. from iceberg) #14292
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…dinality" this ubigint sthe exact cardinality of the parquet_scan(), which can span multiple files that one may know from external metadata like the "schema" named_parameter, it is not really public, but intended for duckdb_iceberg
samansmink
reviewed
Oct 9, 2024
There was a problem hiding this comment.
I think this is okay to add, it is is pretty low profile and will improve iceberg queries quite a bit once it uses this.
However, ideally we still just switch iceberg to the MultiFileReader approach unifying delta and iceberg and avoid needing this parameter altogether.
|
the MultiFileReader approach will an improvement, but it will happen in the longer term, so I think this still is useful for merge. |
Mytherin
reviewed
Oct 11, 2024
| @@ -70,8 +70,8 @@ struct ParquetReadBindData : public TableFunctionData { | |||
| // These come from the initial_reader, but need to be stored in case the initial_reader is removed by a filter | |||
| idx_t initial_file_cardinality; | |||
| idx_t initial_file_row_groups; | |||
| idx_t explicit_cardinality; // can be set to inject exterior knowledge on total cardinality (e.g. from a data lake) | |||
There was a problem hiding this comment.
Can we explicitly intitialize this with 0? It seems this is currently uninitialized.
There was a problem hiding this comment.
done, sorry I thought the whole struct was initialized 0
added 2 commits
October 11, 2024 14:36
…cz/duckdb into pb/explicit-parquet-cardinality
|
Thanks! |
github-actions bot
pushed a commit
to duckdb/duckdb-r
that referenced
this pull request
Oct 17, 2024
allow external cardinality information (e.g. from iceberg) (duckdb/duckdb#14292)
github-actions bot
added a commit
to duckdb/duckdb-r
that referenced
this pull request
Oct 17, 2024
allow external cardinality information (e.g. from iceberg) (duckdb/duckdb#14292) Co-authored-by: krlmlr <krlmlr@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
add a new named_parameter for the parquet_scan() called "explicit_cardinality"
this ubigint is the exact cardinality of the parquet_scan(), which can span multiple files that one may know from external metadata
like the "schema" named_parameter, it is not really public, but intended for duckdb_iceberg