Avoid throwing on failure to open extensions's .info file (when force installing) #14272
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…_install) Idea is that if `.info` files ends up being corrupt, you will be stuck in a loop like: duckdb -c "FORCE INSTALL x" IO Error: Failed to read info file for 'x' extension: Try reinstalling the extension using 'FORCE INSTALL x;' And given in the force_install codepath (that is either in case of `FORCE INSTALL` or in case of `UPDATE EXTENSIONS`) the info file will be rewritten in any case I think this is fine. Note that we could also just avoid the read (but only in the case of FORCE INSTALL), but I wanted avoid yet another slightly different codepath.
|
Unsure if |
|
Thanks! |
github-actions bot
pushed a commit
to duckdb/duckdb-r
that referenced
this pull request
Nov 2, 2024
Avoid throwing on failure to open extensions's .info file (when force installing) (duckdb/duckdb#14272) [Python][Dev] Fix up test to work with older version (duckdb/duckdb#14505)
github-actions bot
added a commit
to duckdb/duckdb-r
that referenced
this pull request
Nov 2, 2024
Avoid throwing on failure to open extensions's .info file (when force installing) (duckdb/duckdb#14272) [Python][Dev] Fix up test to work with older version (duckdb/duckdb#14505) Co-authored-by: krlmlr <krlmlr@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Idea is that if
.infofiles ends up being corrupt, you will be stuck in a loop like:And given in the force_install codepath (that is either in case of
FORCE INSTALLor in case ofUPDATE EXTENSIONS) the info file will be rewritten in any case I think this is OK, and there is no need to notify user that this happened.In the LOAD codepath this will still be visible, we only need a way to get unblocked (yes, removing the file works, but it's not super cool).
Note that we could also just avoid the read (but only in the case of proper
FORCE INSTALL), but I wanted avoid yet another slightly different codepath.