[Python Dev] Make sure the GIL is released when the connection+db are being shut down #14113
+31
−16
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I think I'll do some digging through all the paths that lead to I would have never suspected nested |
…ell use it liberally to ensure the gil is held when a py::gil_scoped_release is encountered
|
Thanks! |
github-actions bot
pushed a commit
to duckdb/duckdb-r
that referenced
this pull request
Oct 16, 2024
Less salt (duckdb/duckdb#14173) [Python Dev] Make sure the GIL is released when the connection+db are being shut down (duckdb/duckdb#14113)
github-actions bot
added a commit
to duckdb/duckdb-r
that referenced
this pull request
Oct 16, 2024
Less salt (duckdb/duckdb#14173) [Python Dev] Make sure the GIL is released when the connection+db are being shut down (duckdb/duckdb#14113) Co-authored-by: krlmlr <krlmlr@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes #14105
As part of this fix I realized that my previous assumptions about gil_scoped_release + gil_scoped_acquire were wrong, they are fine to be nested. It's the
gil_scoped_releasethat can't be nested in itself, that causes a crash