Thanks for the PR!

The GetScanFunction for the tableentry can then store additional information (for example a DeltaSnapshot object) in the shared_ptr TableFunction::function_info; which the delta extension can then store in the multifilereader. This allows pinning a delta snapshot during a transaction.

Am I reading this right that this passes in a const TableFunction, but we then modify one of the members of the TableFunction?

How would that work if we have multiple connections all starting transactions at the same time over the same delta table?

No the idea is that we inject some extra info in the TableFunction object we get: https://github.com/samansmink/duckdb_delta/blob/03ed79b2d49fcef28eab9081d28b8105f51f8fb6/src/storage/delta_table_entry.cpp#L44

Then later, the parquet scan calls back into delta like this https://github.com/samansmink/duckdb_delta/blob/03ed79b2d49fcef28eab9081d28b8105f51f8fb6/src/functions/delta_scan.cpp#L550

Thanks, makes sense after discussion - good to go from my side after CI passes

Thanks!