-
Notifications
You must be signed in to change notification settings - Fork 2.5k
Add Taxi Dataset Benchmark #14197
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Add Taxi Dataset Benchmark #14197
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds the benchmarks described in the Billion NYC Taxi Rides Redshift and Taxi Benchmarks blogs.
A description of how to run the benchmark and how the files are generated is available in
benchmark/taxi/README.md
. All files are available for download, the links are in thebenchmark/taxi/files.txt
. and can easily be downloaded by executing:This benchmark consists of 92 compressed, gzipped CSV files, totaling around 50GB of data and approximately 1.8 billion rows. The benchmark queries are inspired by the Taxi Benchmark blog post, with the output results being ordered to guarantee consistency. This allows us to perform result-checking and ensure that the benchmark is accurate.
The addition of this benchmark is also directly related to issues #14111 and #12453, as this process originated as an in-depth attempt to reproduce these issues.
I've also added multiple tests with different methods for loading these CSV files (see tests in
test/sql/copy/csv/taxi/
), but unfortunately, I was not able to reproduce any of the aforementioned issues. However, we now have an easier way to check if they might be reproducible in the future under specific scenarios.@marklit, I followed the steps described in your blog posts. Could you verify that these files are the same as the ones you have? If not, I'm happy to adapt the generation process or the queries to attempt to reproduce the issues you mentioned. :-)
For reviewing this PR, it would be interesting if the reviewer attempted to run the benchmark, and report if something goes wrong, or if the descriptions should be updated.