[Export/Import] Use the DependencyManager to (stable) sort the entries before export #14196
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…te the catalog entries
…inders CatalogEntryRetriever, add tests with created types and dependencies created by them
… dependencies of the generated columns are registered as dependencies of the table
…, don't make any cross-catalog dependencies, detect and properly error when CREATE OR REPLACE statements depend on itself
…recreated by GetInfo in the CatalogEntry
…rder set GetNaiveExportOrder)
Mytherin
approved these changes
Oct 7, 2024
…es, they need to be synced | only with serialization version >= 1.1.0 do we serialize dependencies, to make this test pass we need to enable serializing of the dependencies in order to properly reorder the exported entries
|
Retagging this to feature after all as I think the new dependencies have some risk of introducing new bugs/differences in behavior. Otherwise this is good to go if the CI passes. |
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes https://github.com/duckdblabs/duckdb-internal/issues/3050
This PR is a revival of #10677
We use GetNaiveExportOrder as we already do, but now we use
DependencyManager::ReorderEntriesto make sure a dependent entry gets exported first if the dependency manager is aware that there is a dependency on the entry.