add method to check whether julia connection is open #14195
Merged
+7
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks! |
|
Thanks for the quick merge! Sorry to keep pestering, but would it be possible to tag a release also for the julia package with this and the latest bugfixes? |
github-actions bot
pushed a commit
to duckdb/duckdb-r
that referenced
this pull request
Oct 16, 2024
Avoid schema changes with IF NOT EXISTS (duckdb/duckdb#14143) add method to check whether julia connection is open (duckdb/duckdb#14195)
github-actions bot
added a commit
to duckdb/duckdb-r
that referenced
this pull request
Oct 16, 2024
Avoid schema changes with IF NOT EXISTS (duckdb/duckdb#14143) add method to check whether julia connection is open (duckdb/duckdb#14195) Co-authored-by: krlmlr <krlmlr@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds methods (previously implemented only for
DuckDB.DB) to check whether a connection is open usingBase.isopenand to close it usingBase.close. It is consistent withDuckDB.DBand is also what other julia DB packages do (e.g. MySQL.jl).