subtype DBInterface.Connection in julia client #14193
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
thanks! |
github-actions bot
pushed a commit
to duckdb/duckdb-r
that referenced
this pull request
Oct 16, 2024
[Dev] Fix issue where the InsertStatement::ToString call destroyed the `alias` of the ValuesList (duckdb/duckdb#14171) [Python] Fix a bug with `python_scan_all_frames` reaching the bottom of the frame stack (duckdb/duckdb#14183) subtype DBInterface.Connection in julia client (duckdb/duckdb#14193)
github-actions bot
added a commit
to duckdb/duckdb-r
that referenced
this pull request
Oct 16, 2024
[Dev] Fix issue where the InsertStatement::ToString call destroyed the `alias` of the ValuesList (duckdb/duckdb#14171) [Python] Fix a bug with `python_scan_all_frames` reaching the bottom of the frame stack (duckdb/duckdb#14183) subtype DBInterface.Connection in julia client (duckdb/duckdb#14193) Co-authored-by: krlmlr <krlmlr@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
By subtyping the
DBInterface.Connectiontype from the julia DBInterface package we gain access to a series of additional methods, in particular thedo blocksyntax to automatically close the cursor after the closure in the do block is executed.I imagine not having this was an oversight as
DuckDB.DB(unlikeDuckDB.Connection) was already a subtype ofDBInterface.Connection.