Issue 14189: Fix build when threads are disabled #14190
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for your PR, I think it would be better to follow the other functions in the file and whatever Emscripten does and just return 0. The only place this is used in figuring out a cache slot in the buffer pool, which is not relevant when we compile without threads. E.g. idx_t TaskScheduler::GetEstimatedCPUId() {
#ifndef DUCKDB_NO_THREADS
// other stuff
#else
return 0;
#endif
} |
|
Thanks! |
Closed
2 tasks
github-actions bot
pushed a commit
to duckdb/duckdb-r
that referenced
this pull request
Oct 16, 2024
Issue 14189: Fix build when threads are disabled (duckdb/duckdb#14190)
github-actions bot
added a commit
to duckdb/duckdb-r
that referenced
this pull request
Oct 16, 2024
Issue 14189: Fix build when threads are disabled (duckdb/duckdb#14190) Co-authored-by: krlmlr <krlmlr@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Return 0 for CPU ID if CPU ID cannot be determined and thread ID cannot be used because threads are disabled - fix issue #14189