[Adaptive Sniffer] In case files have only one row, be more permissive to detect headers and types. #14174
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for the PR! I wonder if we should be sniffing over multiple files when the files are small, similar to what we do in the JSON reader? That would perhaps more robustly fix the issue. |
Mytherin
reviewed
Oct 4, 2024
Mytherin
reviewed
Oct 11, 2024
|
Thanks - one more comment, otherwise LGTM |
|
Thanks! |
github-actions bot
pushed a commit
to duckdb/duckdb-r
that referenced
this pull request
Oct 19, 2024
[Adaptive Sniffer] In case files have only one row, be more permissive to detect headers and types. (duckdb/duckdb#14174)
github-actions bot
pushed a commit
to duckdb/duckdb-r
that referenced
this pull request
Oct 19, 2024
[Adaptive Sniffer] In case files have only one row, be more permissive to detect headers and types. (duckdb/duckdb#14174)
github-actions bot
pushed a commit
to duckdb/duckdb-r
that referenced
this pull request
Oct 19, 2024
[Adaptive Sniffer] In case files have only one row, be more permissive to detect headers and types. (duckdb/duckdb#14174)
github-actions bot
added a commit
to duckdb/duckdb-r
that referenced
this pull request
Oct 19, 2024
[Adaptive Sniffer] In case files have only one row, be more permissive to detect headers and types. (duckdb/duckdb#14174) Co-authored-by: krlmlr <krlmlr@users.noreply.github.com>
krlmlr
added a commit
to duckdb/duckdb-r
that referenced
this pull request
Oct 20, 2024
[Adaptive Sniffer] In case files have only one row, be more permissive to detect headers and types. (duckdb/duckdb#14174) Co-authored-by: krlmlr <krlmlr@users.noreply.github.com>
github-actions bot
pushed a commit
to duckdb/duckdb-r
that referenced
this pull request
Oct 30, 2024
[Adaptive Sniffer] In case files have only one row, be more permissive to detect headers and types. (duckdb/duckdb#14174)
github-actions bot
pushed a commit
to duckdb/duckdb-r
that referenced
this pull request
Oct 30, 2024
[Adaptive Sniffer] In case files have only one row, be more permissive to detect headers and types. (duckdb/duckdb#14174)
github-actions bot
pushed a commit
to duckdb/duckdb-r
that referenced
this pull request
Oct 31, 2024
[Adaptive Sniffer] In case files have only one row, be more permissive to detect headers and types. (duckdb/duckdb#14174)
github-merge-queue bot
pushed a commit
to duckdb/duckdb-r
that referenced
this pull request
Oct 31, 2024
[Adaptive Sniffer] In case files have only one row, be more permissive to detect headers and types. (duckdb/duckdb#14174) Co-authored-by: krlmlr <krlmlr@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When globbing multiple CSV files, if a file that would be ran with the adaptive sniffer only has one row, the adaptive sniffer could misidentify if the one row would be a header or a data row.
This PR extends the checks to identify this case, and adds tests for it.
Fix: #14166